Review "WhoisThat VPN Indicator" version 1 - GNOME Shell Extensions

Review of "WhoisThat VPN Indicator" version 1

Details Page Preview

WhoisThat VPN Indicator

by kvunoff

Live status, speed monitor and quick controls for WhoisThat VPN client (https://github.com/kvunoff/whoisthat)

Extension Homepage: https://github.com/kvunoff/whoisthat-extension

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:114

        this.menu.connect('open-state-changed', (_menu, isOpen) => {
            if (isOpen && this._state.core_running) {
                this._refreshProfilesMenu();
            }
        })

All Versions

Version	Status
1	Unreviewed