Review "Pin Folders to Dash" version 1 - GNOME Shell Extensions

Review of "Pin Folders to Dash" version 1

Details Page Preview

Pin Folders to Dash

by TheOrsia

Allow to pin app folders to dash.

Extension Homepage: https://github.com/TheOrsia/pin-app-folders-to-dash

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-P-003 error

GSettings schema XML must be present in package

Extension appears to use GSettings but no `.gschema.xml` file is included in the package.

GSettings Schemas

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

extension.js:134

            GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                if (isFavorite)
                    appFavorites.removeFavorite(id);
                else
                    appFavorites.addFavorite(id);

                return GLib.SOURCE_REMOVE;
            })

All Versions

Version	Status
1	Unreviewed