Review of "VirtualBox applet" version 21

Details Page Preview

Provide menu to run VirtualBox machines and switch between running VMs

Extension Homepage
https://github.com/eugene-rom/vbox-applet

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • extension.js:104
    GLib.spawn_command_line_sync( cmd )
  • extension.js:166
    GLib.spawn_command_line_sync( 'vboxmanage list runningvms' )

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:44
    this.menu.actor.connect( 'notify::visible', this._onVisibilityChanged.bind(this) )

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
21 Active
20 Active
19 Active
18 Active
17 Active
16 Active
15 Active
14 Rejected
13 Active
12 Active
11 Active
10 Rejected
9 Active
8 Rejected
7 Inactive
6 Active
5 Active
4 Active
3 Active
2 Inactive
1 Inactive

Previous Reviews on this Version

JustPerfection active