Review of "LED Scroller" version 1

Details Page Preview

A scrolling LED marquee that fills the top bar behind its buttons, or sits in it as a button of its own. Set the message, font, speed, direction, LED colour, size and glow in the preferences.

Extension Homepage
https://github.com/rncoll7/led-scroller-gnome

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-003 warning

extensions should not call run_dispose in extension code

Extension code should not call `run_dispose()`.

GObject.Object.run_dispose

  • sign.js:84
    this._timeline.run_dispose()

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:26
    this._pause = new PopupMenu.PopupSwitchMenuItem('Pause', false)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:26
    this._pause = new PopupMenu.PopupSwitchMenuItem('Pause', false)
  • extension.js:22
    this._settings = extension.getSettings()

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

rncoll7 auto- rejected
Auto-rejected because of new version 2 was uploaded