Review of "Open .desktop file location" version 1.0.2 (4)

Details Page Preview

Opens the location of the applications .desktop file

Extension Homepage
https://github.com/laurawebdev/open-desktop-location

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • locales/ru.po
    locales/ru.po
  • locales/messages.pot
    locales/messages.pot

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:59
    this._customMenuItemFile = new PopupMenu.PopupMenuItem(_('Open .desktop file'))
  • extension.js:40
    this._customMenuItemFolder = new PopupMenu.PopupMenuItem(_('Open .desktop location'))

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:59
    this._customMenuItemFile = new PopupMenu.PopupMenuItem(_('Open .desktop file'))
  • extension.js:40
    this._customMenuItemFolder = new PopupMenu.PopupMenuItem(_('Open .desktop location'))

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
1.0.2 (4) Rejected
1.0.1 (3) Rejected
1.0.1 (2) Active
1.0.0 (1) Active

Previous Reviews on this Version

JustPerfection rejected
Please remove unnecessary files: - `locales/messages.pot` - `locales/ru.po` https://gjs.guide/extensions/development/translations.html