Review of "Disable Ubuntu Dock" version 4

Details Page Preview

This extension disables the Ubuntu dock (Ubuntu 17.10+), and can also disable default extensions of a special session (Ubuntu/GNOME Classic).

Extension Homepage
https://github.com/Maestroschan/Disable-Ubuntu-Dock/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

All Versions

Version Status
4 Rejected
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

maweki posted a review
please don't self-reject your uploads. This makes it harder to review incrementally.
Maoschanz posted a review
oh sorry
maweki posted a review
Review put on hold because of possible trademark issues. Please be patient while we sort this out on our end.
Maoschanz posted a review
i can rename it, it's not a problem
maweki waiting for author
Does the session need restarting to revert the changes? We generally don't want that. enable();disable() should, at least observably, be a neutral operation. Is that the case with your changes?
Maoschanz posted a review
Yes, the session need restarting because for example, the extension can't reload the dock in the disable() since the dock would be visible on the lock screen. It's a bug i didn't see at first because i never lock my screen, and i tought the desactivation mecanism was smart enough, but it isn't (so i deactivate the extension before the actual 17.10 release). Then i tought "it can just send a notification, at least there is no security issue like 'the damn dock on the lock screen'", but always having a notification "you need to restart blablabla" at each locking was also ugly. So i did that. I began that extension during the 17.10 beta, before knowing about the simple "sudo apt install gnome-session", but i'm aware it's a really ugly piece of code, and users now have a better solution if they want, so i don't really care if you reject it
maweki rejected
Okay. It's always a balancing act between allowing users to customize their experience and not breaking the stuff that exists for our least technical users. But I understand the technical limitations for what you were trying to do. Having extensions deactivate during locking is good for some, bad for others. Then let's keep this extension deactivated for now. Thank you for your understanding. Should the situtation/code/circumstances change, we can continue at this point. All the best Mario