Review "CMF Headphone Pro Controls" version 1 - GNOME Shell Extensions

Review of "CMF Headphone Pro Controls" version 1

Details Page Preview

CMF Headphone Pro Controls

Control CMF Headphone Pro noise, sound, and device settings from GNOME Quick Settings.

Extension Homepage: https://github.com/dlc4sacchi/gnome-shell-extension-cmf-headphone-pro

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

extension.js:38

Gio.File.new_for_path(CONFIG_PATH).load_contents(null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:312

        this._configMonitor.connect('changed', (_monitor, file) => {
            if (file.get_basename() === 'config.json')
                this._indicator?._tile.reloadConfig();
        })

All Versions

Version	Status
1	Unreviewed