Review "Gnockoff Tiles" version 1 - GNOME Shell Extensions

Review of "Gnockoff Tiles" version 1

Details Page Preview

Gnockoff Tiles

A knockoff of the macOS Tiles app, for GNOME. Tile windows into any corner or into third, half, or two-thirds width columns with keyboard shortcuts, cycle through grid sizes on repeated keystrokes, and resize adjacent tiled windows together. Includes customizable gaps, center alignment, and a tray menu.

Extension Homepage: https://github.com/episode6/gnome-shell-extension-gnockoff-tiles

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 2

Shexli found 4 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

windowMover.js:61

window.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

windowMover.js:55
```
window.get_maximized()
```

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

extension.js:67
```
this._settings = this.getSettings()
```

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:77

    this._settings.connect('changed::override-system-keybindings', () => {
      if (this._settings.get_boolean('override-system-keybindings')) {
        this._applyWorkspaceKeybindingsOverride()
      } else {
        this._resetWorkspaceKeybindings()
      }
    })

All Versions

Version	Status
1	Unreviewed