Review of "NVIDIA SMI Indicator" version 3

Details Page Preview

Shows live GPU VRAM usage in the top bar; click for a per-GPU summary, the processes using the GPU, and the full nvidia-smi output.

Extension Homepage
https://github.com/Nyndow/nvidia-smi-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3 manual_review 1

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:75
    GLib.file_get_contents(`/proc/${pid}/cmdline`)
  • extension.js:87
    GLib.file_get_contents(`/proc/${pid}/comm`)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:345
    St.Clipboard.get_default()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:274
            this.menu.connect('open-state-changed', (menu, isOpen) => {
                if (isOpen) {
                    this._renderMenu();
                    this._pollGpus();
                    this._startDetailPolling();
                } else {
                    this._stopDetailPolling();
                    this._rawPin

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Active