Review of "Litsycal" version 6

Details Page Preview

A compact calendar for the GNOME panel, inspired by Itsycal for macOS. Click the panel badge for a small month calendar with an agenda of your upcoming events, using the calendars GNOME already knows about (GNOME Calendar and Online Accounts such as Google). - Create, edit, search and delete events right from the panel, including quick-add from a one-liner like "Lunch tomorrow 12pm at Cafe Nero" - One-click join buttons and an optional countdown for video meetings - Live world clocks with the offset from your home time zone - Week numbers, pinning, Itsycal-style keyboard shortcuts and plenty of appearance options Clipboard: an agenda event's right-click menu has a "Copy" action that copies the event's details to the clipboard.

Extension Homepage
https://github.com/mlkonrad/litsycal

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • calendarWidget.js:1540
    St.Clipboard.get_default()

All Versions

Version Status
8 Active
7 Rejected
6 Active
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

mlkonrad posted a review
Hello! This is a follow-up regarding the fixes requested in version 5: 1) Comments now use plain ASCII 2) Now all signal connections in the extension process use connectObject()/disconnectObject() 3) Icons were replaced with symbolic St.Icons 4) The day cell and footer tooltips now use separate timeout ids 5) The early return in FloatingModalPanel._finish() was removed 6) _onFinish() was actually called from the base class's _finish(), which every close path (including destroy() on disable) goes through. To make that visible, SearchPanel now overrides _finish() directly and calls super._finish()
JustPerfection active