Review of "Gnube Config Manager" version 0.1 (2)

Details Page Preview

Switch kubeconfig files and kubectl contexts from the top bar. Supports multiple kubeconfig paths, optional merging, and exporting KUBECONFIG.

Extension Homepage
https://github.com/dav1x/gnube-config-manager

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 8 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • kubeEnv.js:177
    console.error(`${extensionUuid}: cannot replace managed kubeconfig: ${e}`)
  • kubeEnv.js:214
    console.error(`${extensionUuid}: managed kubeconfig update failed, using raw paths: ${e}`)
  • kubeEnv.js:220
    console.error(`${extensionUuid}: GLib.setenv(KUBECONFIG) did not stick`)
  • kubeEnv.js:233
    console.error(`${extensionUuid}: failed to write environment.d: ${e}`)
  • kubeEnv.js:244
    console.error(`${extensionUuid}: failed to write shell env file: ${e}`)
  • kubeEnv.js:259
    console.error(`${extensionUuid}: failed to write bashrc.d snippet: ${e}`)
  • kubeEnv.js:267
    console.error(`${extensionUuid}: systemctl set-environment failed: ${e}`)
  • kubeEnv.js:276
    console.error(`${extensionUuid}: dbus-update-activation-environment failed: ${e}`)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • kubeIndicator.js:43
    console.error(`${this._extensionObject.metadata.uuid}: ${e}`)
  • kubeIndicator.js:60
    console.error(`${this._extensionObject.metadata.uuid}: ${e}`)
  • kubeIndicator.js:156
    console.error(`${this._extensionObject.metadata.uuid}: ${e}`)
  • kubeIndicator.js:198
    console.error(`${this._extensionObject.metadata.uuid}: ${e}`)
  • kubeIndicator.js:238
    console.error(`${this._extensionObject.metadata.uuid}: ${e}`)
  • kubeIndicator.js:247
    console.error(`${this._extensionObject.metadata.uuid}: populate menu failed: ${e}`)
  • kubeIndicator.js:278
    console.error(`${this._extensionObject.metadata.uuid}: select cluster failed: ${e}`)
  • kubeIndicator.js:307
    console.error(`${this._extensionObject.metadata.uuid}: select context failed: ${e}`)
  • kubeIndicator.js:352
    console.error(`${this._extensionObject.metadata.uuid}: ${e}`)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • kubePopupMenuItem.js
  • lib/yaml/Dumper.js
  • lib/yaml/Escaper.js
  • lib/yaml/Exception/DumpException.js
  • lib/yaml/Exception/ParseException.js
  • lib/yaml/Exception/ParseMore.js
  • lib/yaml/Inline.js
  • lib/yaml/Parser.js
  • lib/yaml/Pattern.js
  • lib/yaml/Unescaper.js
  • lib/yaml/Utils.js
  • lib/yaml/Yaml.js
  • utils.js

All Versions

Version Status
0.1 (3) Unreviewed
0.1 (2) Active
0.1 (1) Rejected

Previous Reviews on this Version

JustPerfection active
`this._destroyed` is a bad practice. Please remove that: https://gjs.guide/extensions/review-guidelines/best-practices.html#lifecycle-and-destruction-state