Review of "Home Assistant Tiles" version 1.0 (1)

Details Page Preview

Control Home Assistant from GNOME Quick Settings. Live updates over a single WebSocket subscription, Home Assistant areas and icons, custom groups, and controls that follow what each device supports: switches, brightness, color, color temperature, covers, fans, numbers and sensors.

Extension Homepage
https://github.com/slimani-dev/ha-tiles

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • lib/widgets.js:82
    this.actor = new PopupMenu.Switch(false)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • lib/widgets.js:82
    this.actor = new PopupMenu.Switch(false)

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • lib/widgets.js:56
            this._timer = GLib.timeout_add(GLib.PRIORITY_DEFAULT, SLIDER_COMMIT_MS, () => {
                this._timer = 0;
                this._commit();
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
1.0 (1) Unreviewed

Previous Reviews on this Version

moh-slimani posted a review
moh-slimani posted a review