Review of "Wetterkurve" version 3

Details Page Preview

A compact three-day weather chart for up to three saved locations

Extension Homepage
https://github.com/vibecodingwean/wetterkurve

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:572
            this._bigIcon = new St.Icon({
                gicon: this._weatherIcon('unknown'),
                icon_size: 42,
                style_class: 'mw-big-icon',
            })
  • extension.js:622
    this._chart = new ForecastChart()
  • extension.js:515
            this._locationBar = new St.BoxLayout({
                style_class: 'mw-location-bar',
                x_expand: true,
            })
  • extension.js:519
            this._locationTabs = new St.BoxLayout({
                style_class: 'mw-location-tabs',
                x_expand: true,
            })
  • extension.js:491
            this._panelIcon = new St.Icon({
                gicon: this._weatherIcon('unknown'),
                icon_size: 17,
                style_class: 'mw-panel-icon',
            })
  • extension.js:578
            this._refreshButton = new St.Button({
                label: '↻',
                style_class: 'mw-refresh-button',
                can_focus: true,
                accessible_name: this._t('refreshWeather'),
            })
  • extension.js:524
            this._removeLocationButton = new St.Button({
                label: '−',
                style_class: 'mw-location-remove-button',
                can_focus: true,
                visible: false,
            })
  • extension.js:535
            this._searchBox = new St.BoxLayout({
                vertical: true,
                style_class: 'mw-search-box',
                x_expand: true,
                visible: false,
            })
  • extension.js:541
            this._searchEntry = new St.Entry({
                hint_text: this._t('searchLocation'),
                can_focus: true,
                style_class: 'mw-search-entry',
                x_expand: true,
            })
  • extension.js:553
            this._searchResults = new St.BoxLayout({
                vertical: true,
                style_class: 'mw-search-results',
                x_expand: true,
            })

EGO-L-008 warning

Soup.Session instances should be aborted during cleanup

Soup.Session instances should be aborted during cleanup.

Soup.Session.abort

  • extension.js:398
            this._session = new Soup.Session({
                user_agent: `${this.metadata.name}/1`,
                timeout: 20,
            })

All Versions

Version Status
4 Unreviewed
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

vibecodingwean auto- rejected
Auto-rejected because of new version 4 was uploaded