Review of "Reinschrift" version 1.1.0 (1)

Details Page Preview

Your Reinschrift “My Day” in the top bar: see the tasks planned for today and tick them off without opening the app. Reads and writes the same Markdown file as the Reinschrift app (local or Nextcloud-synced).

Extension Homepage
https://reinschrift.dumke.me

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:417
            this._menu.connect('open-state-changed', (_menu, open) => {
                if (open) {
                    this._scheduleRebuild();
                } else if (this._showCompleted) {
                    // Start collapsed again next time.
                    this._showCompleted = false;
                    this._sc
  • extension.js:580
    this._monitor.connect('changed', () => this._scheduleRebuild())
  • extension.js:700
            section.actor.connect('child-added', (_box, child) => {
                child.connect('key-focus-in', () =>
                    ensureActorVisibleInScrollView(scroll, child));
            })
  • extension.js:701
                child.connect('key-focus-in', () =>
                    ensureActorVisibleInScrollView(scroll, child))

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:592
            this._rebuildId = GLib.idle_add(GLib.PRIORITY_DEFAULT_IDLE, () => {
                this._rebuildId = 0;
                this._reload();
                return GLib.SOURCE_REMOVE;
            })
  • extension.js:751
            this._settleId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, SETTLE_MS, () => {
                this._settleId = 0;
                this._scheduleRebuild();
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
1.1.0 (1) Unreviewed