Review of "Touchscreen Toggle" version 1

Details Page Preview

Enable or disable touchscreen devices from the top bar (driver-level, works on Wayland and X11)

Extension Homepage
https://github.com/JayCodist/touchscreen-toggle

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:42
    GLib.file_get_contents(STATE_PATH)

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • extension.js:75
    GLib.spawn_sync(null, argv, null, GLib.SpawnFlags.SEARCH_PATH, null)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:154
                item.connect('toggled', () => {
                    if (this.#syncing)
                        return;
                    this.#runHelper(dev.syspath, dev.subsystem, item.state ? 'on' : 'off');
                    this.#rescan();
                })

All Versions

Version Status
1 Unreviewed

Previous Reviews on this Version

jaycodist posted a review