Review of "Network Speed Monitor" version 7

Details Page Preview

Displays the current network speed on the top bar.

Extension Homepage
https://github.com/ajxv/netspeed-monitor

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-C49-002 error

extensions targeting GNOME 49 must not use removed Clutter action classes

This extension explicitly targets GNOME Shell 49 but still uses removed `Clutter.ClickAction` or `Clutter.TapAction`.

Clutter.ClickAction() and Clutter.TapAction()

  • extension.js:48
    new Clutter.ClickAction()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:50
            this._clickAction.connect('long-press', (action, actor, state) => {
              if (state === Clutter.LongPressState.ACTIVATE)
                toggleUnits();
              return true;
            })
  • extension.js:46
    this._clickAction.connect('recognize', toggleUnits)

All Versions

Version Status
8 Active
7 Rejected
6 Active
5 Rejected
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

ajxv auto- rejected
Auto-rejected because of new version 8 was uploaded