Review of "Ask Bar" version 1.2 (3)

Details Page Preview

One shortcut to search everything: apps, windows, files and git projects, commands, developer tools (JSON, JWT, Base64, UUID…), math and web shortcuts. Pin favorites with Alt+Enter and discover features with /help. Press Alt+Space.

Extension Homepage
https://github.com/kaleabcodes/ask-bar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • lib/async.js:114
    St.Clipboard.get_default()
  • providers/actions.js:168
    St.Clipboard.get_default()
  • providers/assistants.js:75
    St.Clipboard.get_default()
  • providers/calculator.js:45
    St.Clipboard.get_default()
  • providers/commands.js:338
    St.Clipboard.get_default()

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • providers/actions.js:204
    GLib.file_get_contents(path)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • providers/types.js

All Versions

Version Status
1.3 (4) Unreviewed
1.2 (3) Rejected
1.1 (2) Rejected
1.0 (1) Rejected

Previous Reviews on this Version

kaleabcodes auto- rejected
Auto-rejected because of new version 1.3 (4) was uploaded