Review of "Multi Display Adjustment" version 1.2.0 (4)

Details Page Preview

Adjust external displays via DDC/CI: • Responsive brightness/contrast sliders • Display names as in Settings • Placement in a Quick Settings tile or under GNOME's volume • Individual/combined control Requires ddcutil-service: https://github.com/samuelcecilio/multi-display-adjustment#1-installation-of-ddcutil-service

Extension Homepage
https://github.com/samuelcecilio/multi-display-adjustment

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • displays-menu.js:234
    this._section = new PopupMenu.PopupMenuSection()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • displays-menu.js:234
    this._section = new PopupMenu.PopupMenuSection()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • displays-menu.js:67
    this._sliderChangedId = this._slider.connect('notify::value', this._onSliderChanged.bind(this))

All Versions

Version Status
1.5.0 (12) Active
1.4.2 (11) Active
1.4.1 (10) Active
1.4.0 (9) Active
1.2.4 (8) Active
1.2.3 (7) Rejected
1.2.2 (6) Rejected
1.2.1 (5) Rejected
1.2.0 (4) Rejected
1.1.1 (3) Rejected
1.1.0 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

ceciliosamuel auto- rejected
Auto-rejected because of new version 1.2.1 (5) was uploaded