Review of "VScreens" version 3

Details Page Preview

Independent virtual desktops per monitor. Each screen has its own spaces; switching one does not move the others.

Extension Homepage
https://github.com/Florian-Bolli/ubuntu_vscreens

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:62
            this._workspaceChangedId = global.workspace_manager.connect(
                'active-workspace-changed',
                () => {
                    if (this._running)
                        this._spaceManager.handleActiveWorkspaceChanged();
                })

All Versions

Version Status
3 Unreviewed
2 Active
1 Rejected

Previous Reviews on this Version

Florian-Bolli posted a review
I tried to improve usability and run / test it on multiple Ubuntu systems and versions
Florian-Bolli posted a review
I tried to improve usability and run / test it on multiple Ubuntu systems and versions
Florian-Bolli posted a review