Review of "Skin Clock" version 2

Details Page Preview

A movable analog desktop clock with selectable skins, size and opacity controls, and a panel menu to show or hide it.

Extension Homepage
https://github.com/arnoxar/skin-clock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:256
    this._clock = new ClockActor(this, this._settings)
  • extension.js:265
            this._visibleItem = new PopupMenu.PopupSwitchMenuItem(
                _('Show clock'),
                this._settings.get_boolean('visible')
            )

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:64
    this._settings.connect(`changed::${key}`, () => this._applySettings())

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:107
            this._timerId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, interval, () => {
                this.queue_repaint();
                return GLib.SOURCE_CONTINUE;
            })

All Versions

Version Status
2 Unreviewed
1 Rejected