Review of "Simple System Monitor" version 1

Details Page Preview

Show current CPU usage, memory usage, CPU temperature, and net speed on panel.

Extension Homepage
https://github.com/M7md-Gamal/gnome-shell-extension-simple-system-monitor

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:54
    inputFile.load_contents(null)
  • extension.js:118
    inputFile.load_contents(null)
  • extension.js:161
    inputFile.load_contents(null)
  • extension.js:206
    inputFile.load_contents(null)
  • extension.js:263
    typeFile.load_contents(null)
  • extension.js:268
    tempFile.load_contents(null)

EGO-X-006 warning

extensions should not use lookupByURL or lookupByUUID for current extension access

Use `this`, `this.getSettings()` or `this.path` instead of `lookupByURL()` or `lookupByUUID()` for the current extension.

`extensionUtils`

  • extension.js:382
    Extension.lookupByUUID('simple-system-monitor@m7md-gamal.github.io')

EGO-L-006 warning

preferences classes should not retain window-scoped objects on instance fields without close-request cleanup

Preferences code stores window-scoped objects on the exported prefs class without `close-request` cleanup.

Destroy all objects

  • prefs.js:76
    this._configuration = new Settings.Prefs(this.getSettings(Settings.SETTING_SCHEMA))

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

ElKabsh posted a review
tested
ElKabsh auto- rejected
Auto-rejected because of new version 2 was uploaded