Review "StackDock" version 1.1 (1) - GNOME Shell Extensions

Review of "StackDock" version 1.1 (1)

Details Page Preview

StackDock

by PapaRascal2020

A dock for GNOME Shell with built-in macOS-style stacks and app folders. Drag one icon onto another to make a folder. Forked from Dash to Dock, and includes code from Dock Stacks.

Extension Homepage: https://github.com/PapaRascal2020/StackDock

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-I-004 warning

extensions should not use imports._gi directly

Direct use of `imports._gi` is discouraged in extensions.

InjectionManager

utils.js:467
```
Gi.gobject_prototype_symbol
```
utils.js:469
```
Gi.gobject_prototype_symbol
```
utils.js:473
```
Gi.hook_up_vfunc_symbol
```

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

locationsWorker.js

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

docking.js:283

this._staticBox = new Clutter.ActorBox()

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

metadata.json
```
shell-version=['49', '50', '51']
```

All Versions

Version	Status
1.1 (1)	Unreviewed