Review of "Clipboard with Passwords" version cwp v2 (2)

Details Page Preview

Clipboard history manager with a built-in password vault: encrypted storage, search, copy-all and paste buttons

Extension Homepage
https://github.com/sergolova/clipboard-with-passwords

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:106
    St.Clipboard.get_default()
  • passwordVaultDialog.js:46
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:1556
                menuItem.imagePreviewBtn.connect('clicked', () => {
                    this.#cancelHoverPreview(menuItem);
                    this.#showImagePreview(entry);
                })
  • extension.js:1594
                menuItem.editBtn.connect('clicked', () => showEditDialog(menuItem, {
                    onSave: () => this._saveEditedItem(menuItem),
                }))
  • extension.js:1637
                menuItem.protectBtn.connect('clicked', () => {
                    entry.setProtected(!entry.isProtected());
                    menuItem.protectBtn.visible = entry.isFavorite();
                    menuItem.protectBtn.child.icon_name = entry.isProtected()
                        ? 'security-high-symbol
  • extension.js:1667
            menuItem.pasteBtn.connect('clicked',
                () => this.#pasteItem(menuItem)
            )
  • extension.js:1687
            menuItem.tagBtn.connect('clicked', () => showTagDialog(menuItem, {
                onSaved: () => this._updateCache(),
            }))
  • extension.js:2546
            dialog.connect('closed', () => {
                const i = this._vaultDialogs.indexOf(dialog);
                if (i !== -1) {
                    this._vaultDialogs.splice(i, 1);
                }
            })
  • extension.js:1560
                menuItem.imagePreviewBtn.connect('enter-event', () => {
                    this.#cancelHoverPreview(menuItem);
                    if (PREVIEW_ON_HOVER) {
                        menuItem.imagePreviewBtn._cwpHoverPreviewId = setTimeout(() => {
                            menuItem.imagePreviewBtn._cwpHo
  • extension.js:1437
            menuItem.actor.connect('key-press-event', (actor, event) => {
                switch (event.get_key_symbol()) {
                    case Clutter.KEY_Delete:
                        if (menuItem.entry.isFavorite()) {
                            if (CONFIRM_ON_PINNED_DELETE) {
                                this
  • extension.js:1572
                menuItem.imagePreviewBtn.connect('leave-event', () => {
                    this.#cancelHoverPreview(menuItem);
                    this.imagePreview.close();
                })

All Versions

Version Status
cwp v2 (2) Unreviewed
cwp v1 (1) Rejected