Review of "Do Not Disturb While Screen Sharing Or Recording" version 8

Details Page Preview

Automatically switches on the "Do Not Disturb" mode while screen sharing or screen recording. As soon as screen sharing/recording is over, "Do Not Disturb" mode will be switched back off. Do Not Disturb mode stops notifications from appearing on your screen to let you focus on your work. Notifications may contain sensitive content that you might not want to show to everyone while you're screen-sharing. It is likely that not all screen recording apps will trigger the extension to do its job. The extension was tested with the Gnome built-in screen recorder.

Extension Homepage
https://github.com/marcinjahn/gnome-do-not-disturb-while-screen-sharing-or-recording-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:329
    file.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:480
    console.log(`Enabling extension ${this.uuid}`)
  • extension.js:562
    console.log(`Disabling extension ${this.uuid}`)
  • extension.js:63
    console.warn("Subscription to screen sharing status failed, the remote access controller cannot be retrieved")
  • extension.js:105
    console.warn("Subscription to fullscreen status failed, the display cannot be retrieved")
  • extension.js:152
    console.warn("Subscription to applications list status failed, the display cannot be retrieved")
  • extension.js:253
    console.warn("Subscription to directories list status failed, the display cannot be retrieved")

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

All Versions

Version Status
8 Rejected
7 Active
6 Active
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection rejected
Please fix issues mentioned by shexli.