Review of "SAO Neon Desktop Widgets" version 1.0.0 (1)

Details Page Preview

A neon clock and live CPU, memory, and network indicators for the GNOME top panel, with an optional desktop HUD.

Extension Homepage
https://github.com/artem123-gif/sao-neon-desktop-widgets

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:51
    GLib.file_get_contents(path)
  • extension.js:215
    GLib.file_get_contents('/proc/uptime')
  • extension.js:219
    GLib.file_get_contents('/proc/net/route')
  • extension.js:229
    GLib.file_get_contents('/proc/stat')
  • extension.js:238
    GLib.file_get_contents('/proc/meminfo')

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:134
    this._hudClock = new St.Label({text: '--:--', style: 'color: #f5f2ff; font-size: 31px; font-weight: 900;'})
  • extension.js:137
    this._hudCpu = new St.Label({text: 'CPU  --%', style: 'color: #22d3ee; font-size: 12px; font-weight: 800;'})
  • extension.js:135
    this._hudDate = new St.Label({text: '', style: 'color: #a5f3fc; font-size: 12px;'})
  • extension.js:138
    this._hudRam = new St.Label({text: 'RAM  --%', style: 'color: #d8b4fe; font-size: 12px; font-weight: 800;'})
  • extension.js:177
    this._missionDate = new St.Label({text: '', style: 'color: #f5f2ff; font-size: 19px; font-weight: 900;'})
  • extension.js:179
    this._missionNet = new St.Label({text: '', style: 'color: #53f2b8; font-size: 11px; font-weight: 800;'})
  • extension.js:178
    this._missionUptime = new St.Label({text: '', style: 'color: #d8b4fe; font-size: 11px; font-weight: 800;'})

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:134
    this._hudClock = new St.Label({text: '--:--', style: 'color: #f5f2ff; font-size: 31px; font-weight: 900;'})
  • extension.js:137
    this._hudCpu = new St.Label({text: 'CPU  --%', style: 'color: #22d3ee; font-size: 12px; font-weight: 800;'})
  • extension.js:135
    this._hudDate = new St.Label({text: '', style: 'color: #a5f3fc; font-size: 12px;'})
  • extension.js:138
    this._hudRam = new St.Label({text: 'RAM  --%', style: 'color: #d8b4fe; font-size: 12px; font-weight: 800;'})
  • extension.js:177
    this._missionDate = new St.Label({text: '', style: 'color: #f5f2ff; font-size: 19px; font-weight: 900;'})
  • extension.js:179
    this._missionNet = new St.Label({text: '', style: 'color: #53f2b8; font-size: 11px; font-weight: 800;'})
  • extension.js:178
    this._missionUptime = new St.Label({text: '', style: 'color: #d8b4fe; font-size: 11px; font-weight: 800;'})

All Versions

Version Status
1.0.0 (1) Unreviewed