Review of "AirBeat" version 2

Details Page Preview

Minimal Internet Radio Player for GNOME Shell

Extension Homepage
https://velomotiv.de/

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 2

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • AirBeatMenu.js:92
    file.load_contents(null)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • AirBeatPlayer.js:37
    console.error(`${TAG} Failed to initialize GStreamer: ${e.message}`)
  • AirBeatPlayer.js:53
    console.error(`${TAG} Could not create playbin3`)
  • AirBeatPlayer.js:68
    console.error(`${TAG} Failed to set pipeline to PLAYING`)
  • AirBeatPlayer.js:76
    console.error(`${TAG} Error in play(): ${e.message}`)
  • AirBeatPlayer.js:78
    console.error(`${TAG} Stack: ${e.stack}`)
  • AirBeatPlayer.js:158
    console.error(`${TAG} Tag parse error: ${e.message}`)
  • AirBeatPlayer.js:165
    console.error(`${TAG} GStreamer error: ${error.message}`)

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['48', '49', '50', '51']

All Versions

Version Status
2 Unreviewed
1 Rejected