Review "LiveEngine" version 1.1.29 (2)

Review of "LiveEngine" version 1.1.29 (2)

Details Page Preview

LiveEngine

Play a video or GIF as the desktop wallpaper on GNOME. A separate GTK4 + GStreamer renderer keeps decoding out of gnome-shell, with hardware-accelerated playback, playlists, lock-screen support, and automatic pause on fullscreen or low battery.

Extension Homepage: https://github.com/gurmeetgupta22/LiveEngine

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 3

Shexli found 5 issues that may need reviewer attention.

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

lib/windows.js:14
```
win.get_maximized()
```

EGO-P-005 error

binary executables and libraries must not be bundled

Package contains files that look like bundled binaries or libraries.

Scripts and Binaries

.git/cursor/crepe/5a1b6e4f5e9de19eea95c9298a1320ec04fea2db/postings.bin
```
binary-like suffix
```
.git/cursor/crepe/5a1b6e4f5e9de19eea95c9298a1320ec04fea2db/index.bin
```
binary-like suffix
```
renderer/__pycache__/liveengine-renderer.cpython-314.pyc
```
binary-like suffix
```

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

install.sh
```
install.sh
```
.git/index
```
.git/index
```
.git/description
```
.git/description
```
.git/HEAD
```
.git/HEAD
```
.git/config
```
.git/config
```
.git/COMMIT_EDITMSG
```
.git/COMMIT_EDITMSG
```
.git/packed-refs
```
.git/packed-refs
```
.git/hooks/pre-push.sample
```
.git/hooks/pre-push.sample
```
.git/hooks/pre-merge-commit.sample
```
.git/hooks/pre-merge-commit.sample
```
.git/hooks/pre-applypatch.sample
```
.git/hooks/pre-applypatch.sample
```

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

schemas/gschemas.compiled
```
schemas/gschemas.compiled
```

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

lib/indicator.js:52

this._checkedId = this._settings.connect('changed::user-paused', () => this._sync())

lib/indicator.js:53

this._muteId = this._settings.connect('changed::mute', () => this._sync())

All Versions

Version	Status
1.1.29 (2)	Unreviewed
1.1.29 (1)	Rejected