Review of "Widgets" version 1

Details Page Preview

macOS Tahoe liquid-glass desktop widgets for GNOME Shell: Clock, Weather, Battery, Bluetooth, System Resources, Media Player, Quick Notes, and App Dock.

Extension Homepage
https://github.com/gurmeetgupta22/Widgets

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 4

Shexli found 5 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • install.sh
    install.sh

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • liquidGlass.js
  • test_all_imports.js
  • widgetManager.js
  • widgets/AppDockWidget.js
  • widgets/BaseWidget.js
  • widgets/BatteryWidget.js
  • widgets/BluetoothWidget.js
  • widgets/ClockWidget.js
  • widgets/MediaWidget.js
  • widgets/NotesWidget.js
  • widgets/SystemWidget.js
  • widgets/WeatherWidget.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:25
                this._gallery.connect('add-widget', (_actor, widgetId) => {
                    this._widgetManager.addWidget(widgetId);
                })
  • extension.js:19
            this._indicator.connect('open-gallery', () => {
                if (this._gallery) {
                    this._gallery.close();
                    this._gallery = null;
                }
                this._gallery = new WidgetGallery(this._availableWidgets);
                this._gallery.connect('add-widget', (
  • extension.js:47
            this._indicator.connect('open-settings', () => {
                this.openPreferences();
            })
  • extension.js:31
            this._indicator.connect('toggle-edit-mode', () => {
                const isEditing = this._widgetManager.toggleEditMode();
                if (isEditing) {
                    Main.notify('Widgets: Edit Mode', 'Drag widgets to rearrange or click ✕ to remove. Click top bar icon to finish.');
               
  • extension.js:38
            this._indicator.connect('toggle-lock', () => {
                const locked = this._widgetManager.toggleLock();
                this._indicator.setLockState(locked);
            })
  • extension.js:43
            this._indicator.connect('toggle-visibility', () => {
                this._widgetManager.toggleVisibility();
            })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
1 Unreviewed