Review of "Critter" version 0.1.0 (1)

Details Page Preview

A pixel-art desktop pet. Cats, birds, fish and bugs live on your desktop: they walk along the bottom of your screens, sit on window title bars, climb walls or fly, and react to what you do. Feed them, pet them, play with them, watch them grow from an egg to a senior, and unlock achievements. No network access, and nothing you type or read is ever recorded.

Extension Homepage
https://github.com/SoftMadHatter/gnome-critter

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 8 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • lib/manager.js:145
    console.warn(`Critter: pack "${id}", "behavior" keys ignored: ${behavior.ignored.join(', ')}`)
  • lib/manager.js:149
    console.warn(`Critter: pack "${id}", "needs" keys ignored: ${needs.ignored.join(', ')}`)
  • lib/manager.js:153
    console.warn(`Critter: pack "${id}", "anchors" keys ignored: ${anchors.ignored.join(', ')}`)
  • lib/manager.js:157
    console.warn(`Critter: pack "${id}", "stages" keys ignored: ${stages.ignored.join(', ')}`)
  • lib/manager.js:161
    console.warn(`Critter: pack "${id}", translations ignored: ${translations.ignored.join(', ')}`)
  • lib/manager.js:166
    console.warn(`Critter: pack "${id}", achievements ignored: ${achievements.ignored.join(', ')}`)
  • lib/manager.js:170
    console.warn(`Critter: pack "${id}", tricks ignored: ${tricks.ignored.join(', ')}`)
  • lib/manager.js:190
    console.warn(`Critter: egg sprite unavailable (${e.message})`)

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • lib/packLoader.js:136
    packFile.load_contents(null)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • core/index.js

All Versions

Version Status
0.1.1 (3) Unreviewed
0.1.1 (2) Rejected
0.1.0 (1) Rejected

Previous Reviews on this Version

SoftMadHatter auto- rejected
Auto-rejected because of new version 0.1.1 (2) was uploaded