Review of "Custom Alert Sounds" version 2

Details Page Preview

Add custom .ogg files as GNOME alert sounds from Quick Settings - no sudo required.

Extension Homepage
https://github.com/christoph-teichmeister/gnome-custom-alert-sounds

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 8 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • alertManager.js:94
    console.error(`[custom-alert-sounds] getCustomSounds: ${e.message}`)
  • alertManager.js:127
    console.error(`[custom-alert-sounds] getCurrentSound: ${e.message}`)
  • alertManager.js:170
    console.error(`[custom-alert-sounds] setSound: ${e.message}`)
  • alertManager.js:212
    console.error(`[custom-alert-sounds] restore: ${e.message}`)
  • alertManager.js:231
          console.error(
            "[custom-alert-sounds] previewSound: no audio player found (paplay/pw-play)",
          )
  • alertManager.js:255
    console.error(`[custom-alert-sounds] previewSound: ${e.message}`)
  • alertManager.js:308
    console.error(`[custom-alert-sounds] _startMonitor: ${e.message}`)
  • alertManager.js:321
    console.error(`[custom-alert-sounds] _ensureDir: ${e.message}`)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:62
          this.menu.connect("open-state-changed", (_menu, open) => {
            if (!open) return;
            this._manager.ensureMonitor();
            this._refreshCustom();
          })

All Versions

Version Status
2 Unreviewed
1 Rejected