Review of "Auto Brightness Toggle" version 6

Details Page Preview

Toggle auto brightness in quick settings Supports making the system brightness slider icon clickable, or adding a dedicated quick settings toggle (or both). Any suggestion is appreciated on GitHub!

Extension Homepage
https://github.com/swinzy/auto-brightness-toggle

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:239
    this._settings.connect(`changed::${SYSTEM_BT_SLIDER_KEY}`, () => {
                this._syncSystemBrightnessSlider();
            })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
10 Active
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

m1nicrusher posted a review
Will check about the warning. One sec.
m1nicrusher auto- rejected
Auto-rejected because of new version 7 was uploaded