Review of "Yoink" version 1.2 (2)

Details Page Preview

Copy on select with a modifier key, clipboard history and terminal shortcuts that work on any keyboard layout. • Hold Shift while selecting text and it goes to the clipboard, ready for Ctrl+V. Works in terminals too, even inside apps that capture the mouse, like Claude Code, Codex, vim or tmux. Pick any modifier combination, or none to copy every selection. • Clipboard history in the top panel or on Super+Shift+V. Passwords from KeePassXC are skipped. • Ptyxis Ctrl+Shift+C, Ctrl+Shift+V and other shortcuts on Cyrillic, Greek and other non-Latin layouts. Clipboard access: the extension reads the text you select and the clipboard, and writes the selection to the clipboard. It keeps the history in memory, and on disk only if you turn that on.

Extension Homepage
https://github.com/semao0/gnome-shell-extension-yoink

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • lib/indicator.js:95
    St.Clipboard.get_default()
  • lib/selectionWatcher.js:47
    St.Clipboard.get_default()

All Versions

Version Status
1.2 (2) Unreviewed
1.1 (1) Unreviewed

Previous Reviews on this Version

semao0 posted a review
Re EGO-A-005: clipboard access is the whole point of the extension, and it's declared in the description. - selectionWatcher.js: on Meta.Selection owner-changed, copies PRIMARY to CLIPBOARD if the configured modifier was held, and reads CLIPBOARD text into the history. Text mimetypes only; entries with x-kde-passwordManagerHint are skipped. - indicator.js: puts a history entry back on the clipboard when clicked. History is in memory unless the user turns on persist-history (file is created 0600). No network. Tested on Shell 46–50.