Review "Perfree Music Wave · 音浪" version 1.1.1 (1)

Review of "Perfree Music Wave · 音浪" version 1.1.1 (1)

Details Page Preview

Perfree Music Wave · 音浪

A GNOME Shell 46 extension for real-time audio visualization, rainbow waveforms, KTV-style lyric highlighting and MPRIS player controls. Supports local lyrics and optional online matching.

Extension Homepage: https://github.com/perfree/Perfree-Music-Wave

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

audio/analyzer.js
audio/dsp.js
helpers/qqmusic-launcher.js

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:86

        this.menu.connect('open-state-changed', (_menu, open) => {
            if (open) {
                this._mpris.refreshPosition();
                this._updateProgress();
                this._popupWave.refresh();
            } else if (this._dragging) {
                this._dragging = false

All Versions

Version	Status
1.1.1 (1)	Unreviewed