Review "Clipboard History" version 1.0.0 (1)

Review of "Clipboard History" version 1.0.0 (1)

Details Page Preview

Clipboard History

A Windows 11 style clipboard history for GNOME Shell. Press your shortcut (Ctrl+Shift+V by default) to open the clipboard history right at the mouse pointer, then click an entry - or move with the arrow keys and press Enter - to paste it into the focused application. Text and images are remembered, entries can be searched, pinned to the top, deleted, and the whole history is kept across logins. The shortcut is fully configurable in the extension's preferences.

Extension Homepage: https://github.com/andreipintilie/gnome-clipboard-extension

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

lib/clipboardManager.js:147
```
item.file.load_contents(null)
```
lib/clipboardManager.js:380
```
this._historyFile.load_contents(null)
```

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

lib/clipboardManager.js:57
```
St.Clipboard.get_default()
```

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:107

        popup.connect('closed', () => {
            if (this._popup === popup)
                this._popup = null;
        })

extension.js:106

popup.connect('paste-requested', () => this._requestPaste())

All Versions

Version	Status
1.0.0 (1)	Unreviewed