Review "Quick Hub & Launch" version 1 - GNOME Shell Extensions

Review of "Quick Hub & Launch" version 1

Details Page Preview

Quick Hub & Launch

by ardlafci

A quick-launch hub for managing your frequently used commands, folders, and links.

Extension Homepage: https://github.com/ardalafci/quick-hub

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

extension.js:31
```
file.load_contents(null)
```

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

extension.js:88
```
St.Clipboard.get_default()
```
extension.js:89
```
St.Clipboard.get_default()
```

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

extension.js:91

                GLib.timeout_add(GLib.PRIORITY_DEFAULT, 1000, () => {
                    menuItem.label.set_text(item.name);
                    return GLib.SOURCE_REMOVE;
                })

All Versions

Version	Status
1	Unreviewed