Review of "Transparent Top Bar (Adjustable transparency)" version 28

Details Page Preview

Fork of: https://github.com/zhanghai/gnome-shell-extension-transparent-top-bar Bring back the transparent top bar in GNOME Shell with adjustable transparency. Does not work well with custom shell themes.

Extension Homepage
https://github.com/lamarios/gnome-shell-extension-transparent-top-bar

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 4 warning 2

Shexli found 6 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-001 error

GSettings schema id must use org.gnome.shell.extensions base

GSettings schema id must start with `org.gnome.shell.extensions`.

GSettings Schemas

  • schemas/ftpix.com.transparentbar.gschema.xml
    id='com.ftpix.transparentbar' path='/com/ftpix/transparentbar/'

EGO-P-002 error

GSettings schema path must use /org/gnome/shell/extensions base

GSettings schema path must start with `/org/gnome/shell/extensions`.

GSettings Schemas

  • schemas/ftpix.com.transparentbar.gschema.xml
    id='com.ftpix.transparentbar' path='/com/ftpix/transparentbar/'

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/ftpix.com.transparentbar.gschema.xml
    id='com.ftpix.transparentbar' path='/com/ftpix/transparentbar/'

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:28
    this._settings.connect('changed', (settings, key) => this.transparencyChanged(settings, key))

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['47', '48', '49', '50', '51']

All Versions

Version Status
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Rejected
17 Active
16 Active
15 Active
14 Active
13 Active
12 Active
11 Active
10 Active
9 Active
8 Rejected
7 Rejected
6 Rejected
5 Active
4 Active
3 Active
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active