Review of "Display Manager" version 2

Details Page Preview

Hardware-accelerated compositor extension for the Display Panel for Wayland GNOME.

Extension Homepage
https://github.com/heloproc/display-panel-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:81
    this._effect = new Clutter.ShaderEffect()

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
3 Unreviewed
2 Unreviewed
1 Active

Previous Reviews on this Version

heloproc posted a review
v2.0.0 Release Notes: - Graphics: Eliminated "Black Crush" using display-grade gain scaling; dark-mode UI text and movie shadows remain distinct and visible. - Alpha: Fixed premultiplied alpha math, preventing jagged window borders and shadow discoloration. - Screenshots: Pauses the shader dynamically when GNOME Screenshot UI is open, eliminating double-dimming. - Performance: Switched to ITU-R BT.709 perceptual saturation; conditional HSV processing saves GPU cycles. - Reviewer feedback: Switched to connectObject()/disconnectObject() for leak-free cleanup; removed invalid destroy() call. - Compatibility: Expanded support for GNOME 45 through 51.
heloproc posted a review
There is some bug for GNOME 51. Needs fixing, will patch the fix soon in next version
heloproc posted a review
There is some bug for GNOME 51. Needs fixing, will patch the fix soon in next version