Review of "Uppercase Input Source Indicator" version 2.0 (4)

Details Page Preview

Makes the current input source (language) indicator uppercase. Works with IBus input method editors, too.

Extension Homepage
https://github.com/AndreyTalanin0x00/uppercase-input-source-indicator

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • InputSourceManagerMonitor.js:54
    this._inputSourceManagerSignalHandlerId = inputSourceManager.connect(signalName, (inputSourceManager) => signalCallback(inputSourceManager))

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['46', '47', '48', '49', '50', '51']

All Versions

Version Status
2.0 (4) Unreviewed
2.0 (3) Active
1.0 (2) Active
1.0 (1) Rejected