EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

• extension.js:90

  this._indicator.connect('destroy', actor => this._onActorDestroyed(actor))

• extension.js:91

  this._indicator.connect('notify::hover', () => this._syncHover())

• extension.js:27

  this._manager.connect('active-changed', () => this._onActiveChanged())

• extension.js:28

  this._manager.connect('changed', () => this._sync())

• extension.js:30

  this._manager.connect('position-changed', () => this._updateProgress())

• extension.js:29

  this._manager.connect('track-changed', () => this._sync())

• extension.js:42

  this._popup.connect('destroy', actor => this._onActorDestroyed(actor))

• extension.js:44

  this._popup.connect('drag-changed', () => this._syncHover())

• extension.js:43

  this._popup.connect('hover-changed', () => this._syncHover())

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

• extension.js:209

                  this._closeId = GLib.timeout_add(GLib.PRIORITY_DEFAULT,
                      Math.max(1, this._settings.get_int('close-delay')), () => {
                          this._closeId = 0;
                          this._popup.close();
                          return GLib.SOURCE_REMOVE;
           

• extension.js:199

                  this._openId = GLib.timeout_add(GLib.PRIORITY_DEFAULT,
                      Math.max(1, this._settings.get_int('open-delay')), () => {
                          this._openId = 0;
                          this._popup.open(this._indicator);
                          return GLib.SOURCE_REMOVE

• extension.js:146

              this._tickId = GLib.timeout_add(GLib.PRIORITY_DEFAULT, TICK_INTERVAL, () => {
                  sinceResync += TICK_INTERVAL;
                  if (sinceResync >= RESYNC_INTERVAL) {
                      sinceResync = 0;
                      this._manager.active?.resync();
                  }