Review of "Smooth Cursor" version 1

Details Page Preview

Add a smooth cursor, physics based, smooth cursor, bouncy clicks and sparks to your pointer. Perfect for aesthetic screen recordings and presentations on Linux.

Extension Homepage
https://github.com/danMoksh/smooth-cursor

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 4

Shexli found 5 issues that may need reviewer attention.

EGO-X-002 warning

extensions should not use synchronous subprocess APIs in shell code

Shell code should avoid synchronous subprocess APIs like `GLib.spawn_command_line_sync()` and `GLib.spawn_sync()`.

Complete Examples

  • extension.js:23
    GLib.spawn_command_line_sync(`cp -r "${sourceDir}" "${iconDir}/"`)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:51
        this._cursorActor = new St.Icon({
          icon_size: this._settings.get_int('cursor-size'),
          fallback_icon_name: 'pointer',
        })

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:31
    this._interfaceSettings = new Gio.Settings({ schema_id: 'org.gnome.desktop.interface' })

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['47', '48', '49', '50', '51']

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

mod4n auto- rejected
Auto-rejected because of new version 2 was uploaded