Review of "IconPing Modern" version 1

Details Page Preview

Modernisierte Fork der IconPing-Erweiterung von Simone Bisi, angepasst für aktuelle GNOME-Shell-Versionen.

Extension Homepage
https://github.com/ulyxesVV/iconping-modern

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:28
    this._icon = new St.Icon({style_class: 'system-status-icon'})
  • extension.js:33
            this._statusItem = new PopupMenu.PopupMenuItem('Warte auf erste Messung', {
                reactive: false,
                can_focus: false,
            })
  • extension.js:40
    this._toggleItem = new PopupMenu.PopupMenuItem('Ping pausieren')

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:33
            this._statusItem = new PopupMenu.PopupMenuItem('Warte auf erste Messung', {
                reactive: false,
                can_focus: false,
            })
  • extension.js:40
    this._toggleItem = new PopupMenu.PopupMenuItem('Ping pausieren')

All Versions

Version Status
1 Unreviewed