Review of "Desktop Picture Frame" version 1

Details Page Preview

Display a slideshow of photos on your desktop, below all windows.

Extension Homepage
https://github.com/Abrahamthefirst/gnome-desktop-picture-frame

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:64
            this._frameOverlay = new St.Widget({
                style: `border-radius: ${radius}px;` +
                       'background-color: rgba(0,0,0,0.18);' +
                       'border: 2px solid rgba(0,0,0,0.42);',
            })
  • extension.js:59
    this._imageActor = new Clutter.Actor({ width, height })

All Versions

Version Status
1 Unreviewed