Review of "Screensavers" version 0.2.2 (1)

Details Page Preview

Run classic X11 screensavers on GNOME Wayland, shown over the lock screen until the screen blanks. Made for a love of Flurry, the screensaver from macOS: XScreenSaver's port of the original Flurry is the default, and any of its roughly 250 other screensavers (or your own program) can run instead. The X11 savers run unmodified through Xwayland and never receive input; a key press or click stops them and shows the unlock prompt. Requires the xscreensaver package (only its screensaver programs are used, not its daemon). Runs in the unlock-dialog session mode because the lock screen is where the screensaver is shown.

Extension Homepage
https://github.com/Yofuness/gnome-screensavers

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 3

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • registry.js:24
    GLib.file_get_contents(path)

EGO-L-007 warning

main loop sources should be removed before being recreated

Main loop sources should be removed before creating a new source on the same field.

Remove main loop sources

  • extension.js:209
                        this._runTimerId = GLib.timeout_add_seconds(GLib.PRIORITY_DEFAULT, 3, () => {
                            this._runTimerId = 0;
                            this._stopSession({resumeFade: false, reason: 'run-time'});
                            return GLib.SOURCE_REMOVE;
                        }

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['51']

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:66
        disable() {
            // Runs on logout and when the extension is turned off; never while
            // locked, because we declare the unlock-dialog session mode.
            this._debug?.destroy();
            this._debug = null;
            this._settings.disconnectObject(this);
            this._cancelRetrigger()

All Versions

Version Status
0.2.4 (2) Unreviewed
0.2.2 (1) Rejected

Previous Reviews on this Version

yofuness auto- rejected
Auto-rejected because of new version 0.2.4 (2) was uploaded