Review of "Grid Desktop" version 8

Details Page Preview

Grid-based desktop widgets and icon management for GNOME. * Desktop icons support: place, organize, and manage files and launchers on the desktop. * Desktop widgets: clock, weather, notes, music, system monitor, clipboard, and image widgets on an aligned grid. * Local clipboard history with quick access. * Drag, resize, and customise each widget independently.

Extension Homepage
https://github.com/pelach/grid-desktop

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • utils/desktopIcons.js:154
    console.warn('[grid-desktop] Nem sikerült beolvasni a desktop bejegyzést:', err)
  • utils/desktopIcons.js:414
    console.warn('Gridgets: Nem sikerült az asztal mappa monitorozása:', e)
  • utils/desktopIcons.js:434
    console.warn('Gridgets: Nem sikerült a kuka monitorozása:', e)
  • utils/desktopIcons.js:494
    console.warn('Gridgets: Nem sikerült a login1 alvásfigyelő bekötése:', e)
  • utils/desktopIcons.js:110
    console.error('[grid-desktop] Nem sikerült lekérni a csatolt meghajtókat:', e)
  • utils/desktopIcons.js:167
    console.error('[grid-desktop] Nem sikerült beolvasni az Asztal mappát:', e)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • widgets/clipboard.js:100
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • utils/storageEngine.js:15
            this._mountAddedId = this._volumeMonitor.connect('mount-added', () => {
                this.refreshAll();
            })
  • utils/storageEngine.js:18
            this._mountRemovedId = this._volumeMonitor.connect('mount-removed', () => {
                this.refreshAll();
            })

All Versions

Version Status
9 Unreviewed
8 Rejected
7 Rejected
6 Rejected
5 Unreviewed
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

pch76 auto- rejected
Auto-rejected because of new version 9 was uploaded