Review of "Other Networks - Quick Switch" version 2

Details Page Preview

Adds Quick Settings toggles for NetworkManager macvlan and ipvlan connections.

Extension Homepage
https://github.com/Palatis/gnome-shell-ext-other-networks

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:252
    this._toggle = new OtherNetworksMenuToggle(this, this._panelIcon)

All Versions

Version Status
0.0.1 (4) Unreviewed
3 Rejected
2 Rejected
1 Unreviewed

Previous Reviews on this Version

Palatis posted a review
Palatis auto- rejected
Auto-rejected because of new version 3 was uploaded