Review "ThinkPad Human Presence (UWB)" version 1

Review of "ThinkPad Human Presence (UWB)" version 1

Details Page Preview

ThinkPad Human Presence (UWB)

Control ThinkPad UWB Human Presence Detection (Auto-Lock, Auto-Unlock, Keep-Awake) from the top panel and Quick Settings.

Extension Homepage: https://github.com/petr/thinkpad-hpd

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

extension.js:29
```
file.load_contents(null)
```

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

po/thinkpad-hpd.pot
```
po/thinkpad-hpd.pot
```
po/cs.po
```
po/cs.po
```

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

schemas/gschemas.compiled
```
schemas/gschemas.compiled
```

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

extension.js:313

            this._configMonitor.connect('changed', () => {
                this.config = readDaemonConfig();
                this._syncUI();
            })

All Versions

Version	Status
1	Unreviewed