Review of "Advanced Media Controller" version 6.6 (32)

Details Page Preview

Media controls for the GNOME Shell panel. Works with any MPRIS player (Spotify, VLC, Rhythmbox, browsers) and lets you switch between several players from tabs in the popup. * Play, pause, skip, shuffle and repeat * Track and artist in the panel with a scrolling label * Optional vinyl record effect on the album art, set per app (double-click the art) * Time-synced lyrics fetched from lrclib.net (single-click the art) * Seekable progress slider with selectable themes * Panel label font, colour and element order settings

Extension Homepage
https://codeberg.org/sanjai-shaarugesh/Advanced-media-controller

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 2

Shexli found 4 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • utils/core/ThemeEngine.js:145
    console.warn(`Could not list themes folder: ${e.message}`)
  • utils/core/ThemeEngine.js:157
    console.warn(`Could not watch ${path}: ${e.message}`)
  • utils/core/ThemeEngine.js:198
    console.warn(`Could not read themes folder: ${e.message}`)
  • utils/core/ThemeEngine.js:439
            console.warn(
              `API install failed, falling back to the archive: ${e.message}`,
            )
  • utils/core/ThemeEngine.js:351
    console.error(`Could not install theme folder: ${e.message}`)
  • utils/core/ThemeEngine.js:371
          console.error(
              _('Could not install theme file: %s').format(e.message)
          )
  • utils/core/ThemeEngine.js:419
          console.error(
              _('Could not export theme: %s').format(e.message)
          )

EGO-I-002 error

Gtk, Gdk and Adw must not be imported in shell process files

GTK library `Gdk` must not be imported in extension process files.

Do not import GTK libraries in GNOME Shell

  • utils/core/builtinThemes.js:2
    import Gdk from "gi://Gdk";
  • utils/ui/MediaControls.js:7
    import Gdk from "gi://Gdk";
  • utils/ui/ProgressSlider.js:7
    import Gdk from "gi://Gdk";

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • utils/core/themeUtils.js:240
    GLib.file_get_contents(metaPath)
  • utils/core/themeUtils.js:249
    GLib.file_get_contents(jsPath)

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
6.6 (36) Unreviewed
6.6 (35) Rejected
6.6 (34) Rejected
6.6 (33) Unreviewed
6.6 (32) Rejected
6.5 (31) Active
6.5 (30) Rejected
6.5 (29) Rejected
6.5 (28) Rejected
6.5 (27) Rejected
6.5 (26) Rejected
6.5 (25) Rejected
6.5 (24) Rejected
6.0 (23) Rejected
6.0 (22) Rejected
6.0 (21) Rejected
20 Active
19 Rejected
18 Rejected
17 Active
16 Rejected
15 Active
14 Active
13 Active
12 Active
11 Rejected
10 Rejected
9 Rejected
8 Active
7 Active
6 Rejected
5 Rejected
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

sanjai auto- rejected
Auto-rejected because of new version 6.6 (34) was uploaded