Review "Visual Tweak" version 1 - GNOME Shell Extensions

Review of "Visual Tweak" version 1

Details Page Preview

Visual Tweak

by bleakwind

Configure some display effects of GNOME Shell.

Extension Homepage: https://github.com/bleakwind/visual-tweak

No comments.

FAQ

You can upload the next version by the same form you've posted this version.
You can change the extension icon by clicking on the icon in your extension page.
In case you want to inactivate an approved version, click on inactivate link in your extension page.
You can find developer guides in gjs.guide.
If you need any help with your extension, you can ask us on GNOME Matrix Channel.

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

po/lang.pot
```
po/lang.pot
```
po/zh_CN.po
```
po/zh_CN.po
```

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

schemas/gschemas.compiled
```
schemas/gschemas.compiled
```

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

extension.js:21

            GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                this._applyStyle();
                return GLib.SOURCE_REMOVE;
            })

extension.js:42

            GLib.idle_add(GLib.PRIORITY_DEFAULT, () => {
                this._applyStyle();
                return GLib.SOURCE_REMOVE;
            })

All Versions

Version	Status
1	Unreviewed