Review of "Password Generator" version 2

Details Page Preview

Generate strong, customizable passwords directly from the GNOME panel. Left-click copies a password to clipboard; right-click opens settings (length, charsets, exclude ambiguous chars). This extension accesses the clipboard.

Extension Homepage
https://github.com/loginone33/Gnome-Password-Generator-Extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:267
    St.Clipboard.get_default()

All Versions

Version Status
4 Active
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
What the file is doing and why not using gsettings schemas (line 79 `extension.js`)?
LoginOne auto- rejected
Auto-rejected because of new version 3 was uploaded
LoginOne posted a review
Thank you for pointing that out! The JSON file was a leftover from early local prototyping and testing of the options menu before setting up the schema. I have completely removed the JSON file and migrated all configuration and user preferences to standard GSettings schemas (org.gnome.shell.extensions.password-generator) using this.getSettings(). A new version with the schema included has been uploaded for review.