EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

• config.js:187

  file.value.load_contents(null)

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

• color_dialog/main.js
• error.js
• floating_exceptions/main.js
• shortcuts_dialog/adjustment_mode_page.js
• shortcuts_dialog/main.js
• shortcuts_dialog/manipulate_window_page.js
• shortcuts_dialog/shortcut_label.js
• shortcuts_dialog/welcome_page.js
• shortcuts_dialog/workspaces_and_displays_page.js

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

• extension.js:161

              this.settings.int.connect('changed::gtk-theme', () => {
                  this.register(Events.global(GlobalEvent.GtkThemeChanged));
              })

• extension.js:166

              this.settings.shell.connect('changed::name', () => {
                  this.register(Events.global(GlobalEvent.GtkShellChanged));
              })

• extension.js:2001

  id = actor.connect('first-frame', () => {
                      this.auto_tiler?.auto_tile(this, win, this.init);
                      grab_focus();
                      actor.disconnect(id);
                  })

• extension.js:2001

  actor.connect('first-frame', () => {
                      this.auto_tiler?.auto_tile(this, win, this.init);
                      grab_focus();
                      actor.disconnect(id);
                  })

• extension.js:1738

          GLib.timeout_add(GLib.PRIORITY_DEFAULT, 20, () => {
              if (this.movements.is_empty()) {
                  func();
                  return GLib.SOURCE_REMOVE;
              }
              else {
                  return GLib.SOURCE_CONTINUE;
              }
          })

• extension.js:483

          GLib.timeout_add(GLib.PRIORITY_LOW, 100, () => {
              this.exception_selecting = true;
              overview.show(ControlsState.WINDOW_PICKER);
              return GLib.SOURCE_REMOVE;
          })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

• extension.js:1374

          GLib.timeout_add(GLib.PRIORITY_LOW, 50, () => {
              if (this.auto_tiler) {
                  for (const container of this.auto_tiler.forest.stacks.values()) {
                      container.restack();
                  }
              }
              const x = attempts;
              attempts +

• extension.js:1738

          GLib.timeout_add(GLib.PRIORITY_DEFAULT, 20, () => {
              if (this.movements.is_empty()) {
                  func();
                  return GLib.SOURCE_REMOVE;
              }
              else {
                  return GLib.SOURCE_CONTINUE;
              }
          })

• extension.js:483

          GLib.timeout_add(GLib.PRIORITY_LOW, 100, () => {
              this.exception_selecting = true;
              overview.show(ControlsState.WINDOW_PICKER);
              return GLib.SOURCE_REMOVE;
          })

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

• prefs.js:9

      getPreferencesWidget() {
          globalThis.shatterShellExtension = this;
          const dialog = settings_dialog_new();
          dialog.show();
          log.debug(JSON.stringify(dialog));
          return dialog;
      }